Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: Fixed overflow issue #1966

Merged
merged 4 commits into from
Sep 3, 2019

Conversation

RunDevelopment
Copy link
Member

This fixed the overflow issue of Toolbar with Prism's Theme selection. The fixed bug can be seen on the plugin pages of Toolbar, Copy to Clipboard, and Show language.

I'm aware that the artificial transfer of the pre margin to the wrapper isn't an elegant solution, so I'm open for suggestions.

@RunDevelopment
Copy link
Member Author

Alright, I changed the implementation.
The "margin transfer" code is now in scripts/code.js. It'll add a hook to get every highlighted element and applies the fix to elements which have been given a toolbar.

scripts/code.js Outdated Show resolved Hide resolved
Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants