Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong line height with prism-coy.css theme in Microsoft Edge #1790

Closed
logiclink opened this issue Mar 5, 2019 · 3 comments · Fixed by #1791
Closed

Wrong line height with prism-coy.css theme in Microsoft Edge #1790

logiclink opened this issue Mar 5, 2019 · 3 comments · Fixed by #1791

Comments

@logiclink
Copy link

The coy theme doesn't have the right line height when rendered with Microsoft Edge 44.17763.1.0 (Microsoft EdgeHTML 18.17763) and the alternating blue and white background doesn't fit to text rows.
This bug doesn't occur in Forefox or Chrome.

coy

The reason is the missing unit of the line-height in "code[class*="language-"], pre[class*="language-"]" in line 17 of prism-coy.css. If changed from "line-height: 1.5;" to "line-height: 1.5em;" the Edge browser works fine.

@mAAdhaTTah
Copy link
Member

Can you provide an online reproducible example?

@logiclink
Copy link
Author

see helloworld_coy.html in the zip archive helloworld_coy.zip, please open with Edge.

@RunDevelopment
Copy link
Member

RunDevelopment commented Mar 5, 2019

Seems like Edge doesn't calculate line-height correctly.
Actually, it's font-size that's wrong.

But isn't the real question why the Coy theme works on the prismjs.com website?
Answer: The indirect font-size: 100% saves Edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants