Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-minification #1686

Open
RunDevelopment opened this issue Jan 1, 2019 · 5 comments
Open

Add auto-minification #1686

RunDevelopment opened this issue Jan 1, 2019 · 5 comments

Comments

@RunDevelopment
Copy link
Member

As discussed here.

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Feb 13, 2019

I would still prefer if the master branch were to only contain sources and the minified files would only be generated for npm publish and such, but that probably wouldn’t work well with Bower.

@RunDevelopment
Copy link
Member Author

@ExE-Boss This also won't work well for the download page.

@kucharzyk
Copy link

It would be also usefull with webjars.

Now I can use all minified files excapt prism.js which is huge.

    <script src="/webjars/prismjs/1.27.0/prism.js"></script>
    <script src="/webjars/prismjs/1.27.0/components/prism-java.min.js"></script>
    <link href="/webjars/prismjs/1.27.0/themes/prism-tomorrow.min.css" rel="stylesheet">
    <script src="/webjars/prismjs/1.27.0/plugins/line-numbers/prism-line-numbers.min.js"></script>
    <link href="/webjars/prismjs/1.27.0/plugins/line-numbers/prism-line-numbers.min.css" rel="stylesheet">

It would be great to add minified version of prism.js

@mAAdhaTTah
Copy link
Member

@kucharzyk Replace prism.js with components/prism-core.min.js. prism.js is core + the web languages (HTML, CSS, JS).


If we ever wanted to go source-only in the repo, that would also probably have to apply to the site as well.

@kucharzyk
Copy link

Thanks @mAAdhaTTah

I just have to replace prism.js to prism-core.min.js and prism-clike.min.js and it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants