-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What are peer dependencies? #1490
Comments
There is no doc for |
That being the case, one would expect, that e.g. Peer dependencies don't do anything for the download page, so what do they do? |
They're currently used by |
I'm currently implementing #1475, so I have a lot of peer dependencies. (Just out of curiosity: Is there anything checking that there are no circular dependencies? ...apart from a stack overflow?) |
I went ahead and fixed the download page. |
I found an other issue related to peer dependencies: The Test Drive page doesn't handle peer dependencies at all. This is very similar to the problem #1417 solved. |
You might be able to tackle it if you'd like. I opened an issue here: mAAdhaTTah/babel-plugin-prismjs#3 The logic is all really here: https://github.com/mAAdhaTTah/babel-plugin-prismjs/blob/master/src/getComponents.js and none of it is babel-specific. It just products an array of component paths, which is used by the babel-specific logic to update the file. |
On an unrelated note: But I'll try. |
If you mean in the babel plugin, you can change that if you'd like. You can post your questions in that issue if you need help. |
Thank you very much. However, I have to say that I am shocked by the lack of strict indentation conventions ;) |
In
components.json
I came acrosspeerDependencies
. What are they?(Is there a doc for
components.json
?)The text was updated successfully, but these errors were encountered: