Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make profilings optional #28

Open
1 of 2 tasks
vgene opened this issue Feb 23, 2021 · 2 comments
Open
1 of 2 tasks

Make profilings optional #28

vgene opened this issue Feb 23, 2021 · 2 comments
Assignees
@gchan510 @vgene
Labels
high-priority new-feature New feature or request

Comments

@vgene
Copy link
Member

vgene commented Feb 23, 2021 •
edited by gchan510
Loading

Make LAMP and SpecPriv optional

  • LAMP
  • SpecPriv
@vgene vgene added new-feature New feature or request high-priority labels Feb 23, 2021
@vgene vgene self-assigned this Feb 23, 2021
@gchan510
Copy link
Collaborator

gchan510 commented Feb 26, 2021 •
edited
Loading

Added option -lamp-ignore to ignore LAMP profile or to indicate that it doesn't exist in f7d44ab
Querying LAMPLoadProfile for number of deps with this option enabled conservatively returns UINT_MAX.

TODOs:

  • Merge LAMP and LAMPLoad into one library (contains identical versions of same pass in each)
  • SpecPriv optional

QUESTIONS:

  • Why is LAMP run twice in our pipeline?
  • SmtxAA is the only pass that uses LAMP directly? Maybe it should be renamed and moved to SCAF at some point.

@sapostolakis
Copy link
Collaborator

I use LAMP results in the aggressive inliner. And then it needs to run again for the post-inlining code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gchan510 gchan510

@vgene vgene

Labels
high-priority new-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gchan510 @vgene @sapostolakis