Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PS-DSWP work #27

Open
vgene opened this issue Feb 23, 2021 · 4 comments
Open

Make PS-DSWP work #27

vgene opened this issue Feb 23, 2021 · 4 comments
Assignees

Comments

@vgene
Copy link
Member

vgene commented Feb 23, 2021

Make PS-DSWP whole pipeline work on KS

@sapostolakis
Copy link
Collaborator

Note that I had the whole pipeline for PS-DSWP working for KS back on June 4th 2019. This might help when trying to get it working again. Back then I reported for KS 2.4x automatic speedup on 8 cores. Spawning workers only once was critical for KS performance since I targeted an inner loop, and functionality-wise handling conditional live-outs and some weird form of reduction were necessary. At some point that summer I changed focus to DOALL and probably some parts (probably codegen and runtime) got broken for PS-DSWP on the way, but it should not be hard to get back on.

@sapostolakis
Copy link
Collaborator

Note that I started with KS because it did not require any speculation and it was a good first test for the PS-DSWP code gen.
The real challenge for PS-DSWP is to support the validation of all the available forms of speculation. See section 9.2.1 in my thesis (https://liberty.princeton.edu/Publications/phdthesis_sa8.pdf#chapter.9). I have discussed that with Susan and she included some thoughts on her Young Arch workshop talk last year.

@vgene
Copy link
Member Author

vgene commented Feb 24, 2021

Susan identified the proble to be reduxremed being turned off and is in the process of getting that back to life.

@sapostolakis
Copy link
Collaborator

Yes, reg redux need to be re-activated. I disabled it at some point to avoid some hassle with LoopDependenceInfo from NOELLE. But my guess is that after planning works again for KS, codegen and runtime will also need some tweaks to get them working again for KS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants