Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/mechanism: Do not check for string value of numpy error embedded in MechanismError #2569

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Jan 9, 2023

String values of errors are not stable and can change between versions.
Fixes 'input_list_of_strings' tests when using numpy>=1.22.x.
Refactor handling of input port execution exceptions to only check calls to 'execute', parameter set/get do not throw exceptions.

Signed-off-by: Jan Vesely [email protected]

…d in MechanismError

string values of errors are not stable and can change between versions.
Fixes 'input_list_of_strings' tests when using numpy>=1.22.x.
Refactor handling of input port execution exceptions to only check calls
to 'execute', parameter set/get do not throw exceptions.

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added the tests Test changes label Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@jvesely jvesely merged commit 44a2f2e into PrincetonUniversity:devel Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant