llvm: Cleanup codegen of mechanisms that modify function return value #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Vesely <[email protected]>
…rams Scalar params can be single element arrays if modulated, 'load_extract_scalar_array_one' helpers handles that case. Signed-off-by: Jan Vesely <[email protected]>
…ctions instead of _gen_llvm_invoke_function The former has direct access to (modulated) parameters. Use those instead of hack direct access to llvm function's arguments. Signed-off-by: Jan Vesely <[email protected]>
… result. Reuse the already set PROBABILITY_LOWER_THRESHOLD result instead of reading the hardcoded index of function return value. Signed-off-by: Jan Vesely <[email protected]>
…ism_functions _gen_llvm_mechanism_functions has direct access to (modulated) mechanism parameters and state so we can drop the hack of accessing function args 0/1 directly. Signed-off-by: Jan Vesely <[email protected]>
…d DDM Signed-off-by: Jan Vesely <[email protected]>
Signed-off-by: Jan Vesely <[email protected]>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
…d PRNG seed Signed-off-by: Jan Vesely <[email protected]>
…ounds Signed-off-by: Jan Vesely <[email protected]>
…r/single element array Signed-off-by: Jan Vesely <[email protected]>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LCControlMechanism and DDM both modify function return values before using them as mechanism values.
Overloading _gen_llvm_mechanism_functions instead of _gen_llvm_invoke_function gives direct
access to modulated mechanism parameters without accessing the LLVM function arguments.
Use helper functions instead of explicitly checking types when possible.
Drop no longer needed shape workarounds.