Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm: Add support for more SoftMax output types #2418

Merged
merged 9 commits into from
May 16, 2022

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented May 16, 2022

Convert MAX_VAL, and MAX_INDICATOR SoftMax output types to use OneHot nested function.
Add support for PROB SoftMax output type.
Add support for compiling PROB standard output.
Check that we're not using combination_function in compiled RTM.
Drop nested parameters and state of combination function if not used in RTM.

jvesely added 9 commits May 6, 2022 12:17
debug configuration is not used in the builtins module.

Signed-off-by: Jan Vesely <[email protected]>
There's no need to go through pnlvm top level module.

Signed-off-by: Jan Vesely <[email protected]>
Drop explicit test ID list.

Signed-off-by: Jan Vesely <[email protected]>
Set a fixed random seed, SoftMax PROB results depend on fixed inputs.

Signed-off-by: Jan Vesely <[email protected]>
Matches Python implementation.

Signed-off-by: Jan Vesely <[email protected]>
…put port

SoftMax Requires 2D input, so pass the entire mechanism value instead of
the default (VALUE, 0).
Improves: PrincetonUniversity#1780

Signed-off-by: Jan Vesely <[email protected]>
Conflicts:
	psyneulink/core/components/mechanisms/processing/processingmechanism.py
	Imported keywords conflict with added 'check_user_specififed'.
	Resolution: Keep both the new keyworkd imports and
	'check_user_specififed' import.
… from compiled structures if not needed

Signed-off-by: Jan Vesely <[email protected]>
@jvesely jvesely added the compiler Runtime Compiler label May 16, 2022
@github-actions
Copy link

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@jvesely jvesely merged commit 0881dbf into PrincetonUniversity:devel May 16, 2022
@jvesely jvesely linked an issue May 17, 2022 that may be closed by this pull request
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Runtime Compiler
Projects
Development

Successfully merging this pull request may close these issues.

Add compiler support for more OutputPort types
1 participant