Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Subscription Handler function has wrong signature. #114

Open
sixtay opened this issue Apr 30, 2022 · 3 comments
Open

Persistent Subscription Handler function has wrong signature. #114

sixtay opened this issue Apr 30, 2022 · 3 comments

Comments

@sixtay
Copy link

sixtay commented Apr 30, 2022

persistentSubscription.on('data', (subscription, payload) => {

This doesn't look correct. Payload will always be undefined and will break. Please advise

@kodeine
Copy link
Contributor

kodeine commented May 5, 2022

@sixtay would you be able to submit a PR for this fix?

@sixtay
Copy link
Author

sixtay commented May 5, 2022

Possibly. It seems this issue stems from the subscription leveraging 'node-eventstore-client' instead of @eventstore/db-client.

I'll look into a fix.

For now I just modified juicyclef's package to create persistent subscriptions and use append to individual aggregate streams.

@kodeine
Copy link
Contributor

kodeine commented May 11, 2022

Juicyjeffs package uses eventstore 5.x. This package supports that in 4.x branch and the master branch should support eventstore 20.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants