Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to task input tab on the task run page #7547

Closed
4 of 8 tasks
zhen0 opened this issue Nov 16, 2022 · 3 comments · Fixed by #8295
Closed
4 of 8 tasks

Update to task input tab on the task run page #7547

zhen0 opened this issue Nov 16, 2022 · 3 comments · Fixed by #8295
Assignees
Labels
ui Related to the Prefect web interface

Comments

@zhen0
Copy link
Member

zhen0 commented Nov 16, 2022

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I refreshed the page and this issue still occurred.
  • I checked if this issue was specific to the browser I was using by testing with a different browser.

Bug summary

Currently the task run page task input tab shows the correct keys but all values are empty. There's a ticket to track api work for that here: #6627 Until that work is done, we should remove the values shown in the tab and only show the keys so that we're not giving the misleading suggestion that all task inputs are empty arrays.

image

Reproduction

Create a flow with tasks and run it - go to the task run page and look at the task inputs tab

Error

image

The [] section is misleading

Browers

  • Chrome
  • Firefox
  • Safari
  • Edge

Prefect version

No response

Additional context

No response

@zhen0 zhen0 added status:accepted ui Related to the Prefect web interface and removed priority:medium labels Nov 16, 2022
@zhen0 zhen0 self-assigned this Dec 13, 2022
@zanieb
Copy link
Contributor

zanieb commented Jan 5, 2023

Note clarification at #6627 (comment) — I do not believe this issue is following correct assumptions.

@jmesterh
Copy link

Just want to note as a new user -- this page is misleading, I thought this was a bug or I had misconfigured Orion and my inputs were being lost. I'm testing an ETL and was hoping I could see what table the task was working on based on the inputs shown on this screen.

@aeisenbarth
Copy link

I came here because this issue describes what I am observing now, although it is marked as resolved and the solutions are merged.

I had to follow all merge requests links and read between the lines to come to the conclusion that for now, only the keys are meaningful and the empty arrays are placeholders (?). This is absolutely not clear from the info modal. It mentions that it can include constants, parameters or other tasks, but no word about whether it means only the keys or whether we should also expect values. In that regard, #8295 does some clarification for other issues, but I don't feel it resolves this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Related to the Prefect web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants