Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable retries for Fargate Agent #2170

Closed
lukeorland opened this issue Mar 18, 2020 · 1 comment · Fixed by #2388
Closed

Enable retries for Fargate Agent #2170

lukeorland opened this issue Mar 18, 2020 · 1 comment · Fixed by #2388
Assignees
Labels
enhancement An improvement of an existing feature

Comments

@lukeorland
Copy link

Current behavior

We invoked client.create_flow_run in a for loop with 365 different parameter values. This caused 258 of them to fail with one of two different errors. In each case there was only run log message for the whole flow run.

March 17th 2020 at 2:32:51am | agent
ERROR 
An error occurred (ThrottlingException) when calling the RunTask operation (reached max retries: 4): Rate exceeded.
March 17th 2020 at 2:32:59am | agent
ERROR 
list index out of rangeMarch 17th 2020 at 2:32:59am | agent
ERROR 
list index out of range

Apparently, for the flow runs that the FargateAgent received an error from the AWS API, the FargateAgent quit and sent the error back to Prefect Cloud.

Proposed behavior

When the FargateAgent receives a throttling error response from AWS, it could retry the request (perhaps using backoff). It appears that botocore already has retry functionality:

boto/botocore#1260

Example

If this were implemented, it would cover the case when a team is running a backfill workflow for every day in a given year, all at once.

@lukeorland lukeorland added the enhancement An improvement of an existing feature label Mar 18, 2020
@joshmeek
Copy link

👍 Thanks for opening. Yeah I think we should take advantage of boto's retry configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants