This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow the new 24hr max timeout for CloudRunJobs #217
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: #99 the max timeout for the
CloudRunJob
class was set to 1hr, following the Cloud Run TaskSpec documentation.Since then, the max timeout has been updated up to 24 hours:
Note: this has been mentioned in an open Issue: #199 for upgrading to V2 of the GCP API, but there are no open issues or PRs for updating the timeout Pydandic validation logic which would enable users to run longer tasks immediately.
This PR
This change updates the Pydantic validation logic to allow up to 24hrs for a Cloud Run job. This will allow users to enter this in the Prefect UI block configuration for long-running jobs even before updating to the V2 API syntax.
Example
Screenshots
Checklist
pre-commit
checks.pre-commit install && pre-commit run --all
locally for formatting and linting.mkdocs serve
view documentation locally.