Error thrown when VM resource's Ensure property equals false #67
Conversation
The VM's VHD's path was being verified when the VM resource's Ensure=false. If the VM doesn't exist, it doesn't make sense to verify that its VHD's Path is valid. The VM is going to be deleted anyway.
|
Good catch! Any chance you can add a test for this so we don't get any regressions? If you need any help with this - let me know 😃 Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Thanks @iainbrighton 😃 I've written Pester tests before, but I'm unfamiliar with "InModuleScope" and "Mock" and I didn't want to deviate from you guys' current methodology. I know it's in the Pester documentation, so I'll have to take a look at it when I get a chance. I'll hit you up if I have any questions, if that's alright. |
kwirkykat
added
the
waiting for author response
Added test for: Error thrown when VM resource's Ensure property equals false #67 It verifies that the Test-TargetResource returns true if the state is "Absent", the VM is missing, and the VHD doesn't exist. If the VM is missing and we wanted it to be so, we don't care if the VHD exists.
|
@iainbrighton , I think I've created the test correctly... It's in a separate pull request, is that okay? |
|
Yes - once you fix the tabs, it looks good to me Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed. Tests/MSFT_xVMHyper-V/xVMHyper-V.Tests.ps1, line 159 at r2 (raw file):
You'll need to get rid of these tabs as they'll fail the style tests. Comments from Reviewable |
bgelens
added
abandoned
|
Assigning abandoned label for now as there has been no response since @iainbrighton last review. And if you do, please also update the Readme Unreleased section with this fix |
…e Present to if present block Redoing work from abandoned PR dsccommunity#67
* moved localizedData to own file * moved parameter validation tests which are only applicable with Ensure Present to if present block * Redoing work from abandoned PR #67 * fixed code styling issues * fixed StartupMemory evaluation in Test-TargetResource * changed wrong localized data variable reference AutomaticCheckpointsUnsupportedError to correct one AutomaticCheckpointsUnsupported * Redoing work from abandoned PR #148 * updated changelog * fix psv5 parsing error and added verbose in Get-TargetResource * Fixed Get throws errors when no NICs or missing NIC properties * fix Null indexing error for Get-TargetResource when VM does not exists * added periods to end of lines in changelog * changed multiline comments to commentblocks
|
Since this PR was abandoned, I redid the work in PR #163 |
The VM's VHD's path was being verified when the VM resource's Ensure=false. If the VM doesn't exist, it doesn't make sense to verify that its VHD's Path is valid. The VM is going to be deleted anyway.
This change is