xVMHyperV - AutomaticCheckpointsUnsupported var name incorrect #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AutomaticCheckpointsUnsupportedError` on line 740 does not resolve to a defined localized data variable and it looks like it should be `AutomaticCheckpointsUnsupported instead. Without this change a meaningless error message is produced: `ScriptHalted` instead of what is should be: `AutomaticCheckpoints are not supported on this host`
|
@Geogboe this PR targets the master branch, I tried to change the base to dev, but that didn't work. I need your help to send in the PR against the dev branch instead. I think we should change the line 15 to 'AutomaticCheckpointsUnsupportedError' instead (the localized string is used at two locations). Also, please add an entry about this change under the Unreleased section in the CHANGELOG.md. |
johlju
added
the
waiting for author response
|
i added an issue #149 to track this. |
|
Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again. |
johlju
added
abandoned
bgelens
added a commit
to bgelens/xHyper-V
that referenced
this pull request
Jan 9, 2019
…nsupportedError to correct one AutomaticCheckpointsUnsupported Redoing work from abandoned PR dsccommunity#148
9 tasks
bgelens
added a commit
that referenced
this pull request
Jan 11, 2019
* moved localizedData to own file * moved parameter validation tests which are only applicable with Ensure Present to if present block * Redoing work from abandoned PR #67 * fixed code styling issues * fixed StartupMemory evaluation in Test-TargetResource * changed wrong localized data variable reference AutomaticCheckpointsUnsupportedError to correct one AutomaticCheckpointsUnsupported * Redoing work from abandoned PR #148 * updated changelog * fix psv5 parsing error and added verbose in Get-TargetResource * Fixed Get throws errors when no NICs or missing NIC properties * fix Null indexing error for Get-TargetResource when VM does not exists * added periods to end of lines in changelog * changed multiline comments to commentblocks
|
Since this PR was abandoned, I redid the work in PR #163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
AutomaticCheckpointsUnsupportedErroron line 740 does not resolve to a defined localized data variable and it looks like it should beAutomaticCheckpointsUnsupportedinstead. Without this change a meaningless error message is produced:ScriptHaltedinstead of what is should be:AutomaticCheckpoints are not supported on this host.Task list:
This change is