Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format rule request: Remove all semicolons at the end of lines #801

Open
adbertram opened this issue May 31, 2017 · 7 comments
Open

Format rule request: Remove all semicolons at the end of lines #801

adbertram opened this issue May 31, 2017 · 7 comments
Labels
Area-Code Formatting Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@adbertram
Copy link
Contributor

I know some people love their semi-colons at the end of lines like in C# but it's not necessary for PowerShell. I'd love to take someone else's code and format the document to remove all of the semicolons from it.

@pcgeek86
Copy link
Contributor

pcgeek86 commented May 31, 2017

Maybe this is better suited for PSScriptAnalyzer? I'd suggest posting this feedback here: https://github.com/PowerShell/PSScriptAnalyzer

@daviwil
Copy link
Contributor

daviwil commented May 31, 2017

Part of the implementation would happen in the PowerShell extension so I'd say we can leave the issue here for tracking purposes.

@pcgeek86 pcgeek86 added Area-Code Formatting Issue-Enhancement A feature request (enhancement). labels May 31, 2017
@rkeithhill
Copy link
Contributor

rkeithhill commented May 31, 2017

This could be a good example of using $psEditor. :-)

@TylerLeonhardt
Copy link
Member

@bergmeister I feel like this can all be handled in PSSA via Formatting. What do you think?

@bergmeister
Copy link
Contributor

bergmeister commented Sep 8, 2019

@TylerLeonhardt Yes, there is already an open issue: PowerShell/PSScriptAnalyzer#824
It should be a small to medium sized task (half a day for someone who knows a bit about PSSA and maybe a full day for a newbie) but personally, I do not see much value and more a 'nice to have', therefore it's up for grabs :-)
If someone wants to start on it, just give me a ping and I can write up a few tips/gotchas about PSSA's formatter legacy (like e.g. the fact that the engine has the formatting rule names to execute hard-coded to avoid the circular reference because the rules know about the engine but not the other way around...)

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Sep 8, 2019
@SydneyhSmith
Copy link
Collaborator

@bergmeister thanks for the response and for linking the issue where this is being tracked, I will go ahead and leave this open as way to track the work that would need to happen to allow this to be a configuration in vscode

@SydneyhSmith SydneyhSmith added Up for Grabs Will shepherd PRs. and removed Needs: Maintainer Attention Maintainer attention needed! labels Sep 10, 2019
@SeeminglyScience
Copy link
Collaborator

SeeminglyScience commented Sep 11, 2019

Anyone who wants to pick this up can use Remove-Semicolon from EditorServicesCommandSuite as guide. Implementing it in PSSA won't be as simple, but that should give an idea of what you're looking for.

Edit: Might be a good idea to make the bot that adds "Needs: Attention" exclude maintainers.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Sep 11, 2019
@SeeminglyScience SeeminglyScience removed the Needs: Maintainer Attention Maintainer attention needed! label Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Code Formatting Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

8 participants