Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve history navigation experience #1235

Open
SteveL-MSFT opened this issue Dec 9, 2019 · 6 comments
Open

Improve history navigation experience #1235

SteveL-MSFT opened this issue Dec 9, 2019 · 6 comments
Labels
Area-HistoryImprovements Label for tracking different improvements to history Issue-Enhancement It's a feature request.

Comments

@SteveL-MSFT
Copy link
Member

SteveL-MSFT commented Dec 9, 2019

Perhaps a blend of menu complete and history searching, seems to be a common ask

Description of the new feature/enhancement

There are many cases where tab completion can result in a large list (not just files which is a common case, but think of resources in Azure). It would be useful to have either a new mode for MenuComplete or an alternate where you have a filter line that will dynamically filter results showing matches to the typed filter. In the file case, I should be able to type *.jpg which will filter out to just files with that extension. If I type jpg then any result that contains that string would be shown.

One question is whether the cmdlet participates as an optimization rather than filtering on the client.

@SteveL-MSFT SteveL-MSFT added this to the 3.0.0-Consider milestone Dec 9, 2019
@lzybkr
Copy link
Member

lzybkr commented Dec 9, 2019

Unless you meant for this to be a meta-issue - there are plenty of existing issues, e.g. #82, #120, #122, and #1074.

I couldn't find the issue quickly, but I also suggested displaying some sort of status indicator showing where you are in the history, e.g. 342/4096 or something like that. It might be confusing, but it might be helpful when you start to get lost.

@SteveL-MSFT SteveL-MSFT added the Issue-Enhancement It's a feature request. label Dec 9, 2019
@lzybkr
Copy link
Member

lzybkr commented Dec 10, 2019

fzf provides an nice history searching experience. Install fzf then in bash try Ctrl+r. It adds a couple other useful bindings as well.

Note the PowerShell module PSFzf enables this experience with PSReadLine.

This experience is much nicer on Linux or in wsl because it doesn't take over the entire screen. fzf on Windows doesn't seem to support this yet.

@SteveL-MSFT
Copy link
Member Author

Fuzzy searching is something I wanted to enable as well, so we should definitely look at fzf.

@lzybkr
Copy link
Member

lzybkr commented Apr 21, 2020

@kelleyma49 - thanks, I'm not sure when it was added but I noticed last week - and it makes a huge difference in usability.

@kelleyma49
Copy link

kelleyma49 commented Apr 21, 2020

I had submitted a pull request back in 2018. It finally got merged in early March of this year.

I agree that it makes fzf much more usable. Let me know if you have any feature requests for PSFzf!

@StevenBucher98 StevenBucher98 added the Area-HistoryImprovements Label for tracking different improvements to history label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-HistoryImprovements Label for tracking different improvements to history Issue-Enhancement It's a feature request.
Projects
None yet
Development

No branches or pull requests

4 participants