Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Block Tags #183

Closed
TheBedrockMaster opened this issue Dec 18, 2024 · 7 comments
Closed

Storage Block Tags #183

TheBedrockMaster opened this issue Dec 18, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@TheBedrockMaster
Copy link

The following items should have the c:storage_blocks and c:storage_blocks/{material} item and block tags added:

Allium Petal Block: c:storage_blocks/allium
Pink Allium Petal Block: c:storage_blocks/pink_allium
White Allium Petal Block: c:storage_blocks/white_allium
Rose Petal Block: c:storage_blocks/rose

@JT122406
Copy link
Member

I can add the tags, but
Allium Petal Block: c:storage_blocks/allium
Pink Allium Petal Block: c:storage_blocks/pink_allium
White Allium Petal Block: c:storage_blocks/white_allium
Rose Petal Block: c:storage_blocks/rose

would all use the biomeswevegone namespace and not c since they aren't "common" tags they are ours, then all of them would be added to c:storage_blocks

@JT122406 JT122406 self-assigned this Dec 20, 2024
@JT122406 JT122406 added the enhancement New feature or request label Dec 20, 2024
@JT122406 JT122406 added this to the 2.3.0/1.5.0 milestone Dec 20, 2024
@TheBedrockMaster
Copy link
Author

Mods that add specific storage blocks, ingots, etc, still use the c namespace if they can be put as a / after the common tag, like c:storage_blocks/allium

@JT122406
Copy link
Member

What other mods?

@TheBedrockMaster
Copy link
Author

Just to name a few; Mekanism, AllTheOres, Allthemodium, PneumaticCraft, Ars Nouveau, Actually Additions, Advent of Ascension, The Undergarden, Twilight Forest, Croptopia and Applied Energistics 2. Most mods that can add them, do.

@JT122406
Copy link
Member

I see what you are saying I looked at the undergarden, I'm gonna consult some other devs to see what the decision is here as it doesn't make sense to me to use the common id

@TheBedrockMaster
Copy link
Author

If another mod adds a storage block for alliums, it's easier to unify them if they already have the same tag.

@JT122406
Copy link
Member

That only makes sense in the case of MC blocks for blocks that we add it doesn't make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants