fix: uninstall default and import problem #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarqin
reviewed
Mar 13, 2023
| @@ -12,7 +13,8 @@ import { lastValueFrom, Subscription } from 'rxjs'; | |||
| import { ExtensionCommonService } from './extension-store.service'; | |||
| import { WebExtensionService } from './webExtension.service'; | |||
|
|
|||
| const defaultExtensions = ['postcat-export-openapi', 'postcat-import-openapi']; | |||
| const uninstallDefaultExtensions = StorageUtil.get('uninstall_default_ext_list'); | |||
There was a problem hiding this comment.
这里可以优化成第一次打开才安装默认插件，不需要缓存卸载信息。
| mixin: (data, base) => { | ||
| const handleData = {}; | ||
| for (let item of data) { | ||
| handleData[item.name] = { |
There was a problem hiding this comment.
这里没有考虑子参数逻辑（childList）
table 的遍历逻辑可以看看 filterTableData 能否被复用。
yZaio
added a commit
that referenced
this pull request
May 5, 2023
* fix: uninstall default and import --------- Co-authored-by: sunzhouyang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: uninstall default and import problem