Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime property filters should allow relative dates #8640

Closed
pauldambra opened this issue Feb 16, 2022 · 4 comments
Closed

DateTime property filters should allow relative dates #8640

pauldambra opened this issue Feb 16, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@pauldambra
Copy link
Member

pauldambra commented Feb 16, 2022

Is your feature request related to a problem?

A customer using the date time filtering for #6619 asked

if I choose today... will this be today tomorrow as well? eg. always now.

for context I would like to check if a customer still has a subscription by checking a profile param and making sure expiration is in the future.

eg. give me all customers where subscription_expiration > today (now)

Currently the dates chosen in the date picker are all absolute. E.g. a selection of "today" is "yesterday" after one day

Describe the solution you'd like

To be able to choose relative as well as absolute dates

This allows filters like subscription_end_date > today or license expired > seven days ago

Describe alternatives you've considered

Asking people to update insights that should query after a relative date when they want to see it

Additional context

Thank you for your feature request – we love each and every one!

@macobo
Copy link
Contributor

macobo commented Feb 16, 2022

Aside: this might have implications if we ever cache timeseries queries - this kind of filter makes past results unusable.

@pauldambra
Copy link
Member Author

Fair point @macobo... I guess you could pass refresh=true when loading a graph or infer it if that filter is present... But that's not great for load... And might be confusing for users... They might not understand why insight X is fast but insight Y is slow

Tagging @clarkus too

@McKean
Copy link

McKean commented Feb 17, 2022

I understand the complexity with timeseries. Perhaps it would make sense to restrict the dynamic functionality to the filters?
Use case would be for example to only show data from users who have been active since yesterday.
image
Not sure if this would make things easier though...

@pauldambra
Copy link
Member Author

You can now do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants