Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect reporting on Insights #7347

Closed
2 of 3 tasks
paolodamico opened this issue Nov 25, 2021 · 1 comment · Fixed by #7439
Closed
2 of 3 tasks

Incorrect reporting on Insights #7347

paolodamico opened this issue Nov 25, 2021 · 1 comment · Fixed by #7439
Assignees
@Twixes
Labels
bug Something isn't working right P0 Critical, breaking issue (page crash, missing functionality)

Comments

@paolodamico
Copy link
Contributor

paolodamico commented Nov 25, 2021 •
edited
Loading

Bug description / Expected behavior

While exploring the app today, I found some important issues with reporting on insights:

  1. When an insight is viewed from the "View mode" (i.e. when accessed by clicking on a saved insight) we don't trigger "insight viewed" or "insight analyzed". In the event, we should include an attribute that indicates the view mode too.
  2. When opening an insight (funnel or otherwise) from saved insights into "View mode" we trigger correlation viewed & correlation properties viewed automatically even though correlation isn't actually viewed. CC @neilkakkar
  3. We don't report when a user has "compare previous" enabled

How to reproduce

  1. Open an insight from the saved insights list with the JS console open. See events triggered.

Environment

  • PostHog Cloud
  • self-hosted PostHog (ClickHouse-based), version/commit: 1.30.0
  • self-hosted PostHog (Postgres-based, legacy), version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!
@paolodamico paolodamico added bug Something isn't working right team-core-experience labels Nov 25, 2021
@neilkakkar
Copy link
Contributor

For point 2, is this happening all the time for you? I can't seem to reproduce O.o

@paolodamico paolodamico added the P0 Critical, breaking issue (page crash, missing functionality) label Nov 25, 2021
@paolodamico paolodamico mentioned this issue Nov 29, 2021
Closed
58 tasks
@Twixes Twixes mentioned this issue Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Twixes Twixes

Labels
bug Something isn't working right P0 Critical, breaking issue (page crash, missing functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Insight analytics fixes PostHog/posthog
3 participants
@Twixes @paolodamico @neilkakkar