Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature flags #6140

Closed
mariusandra opened this issue Sep 28, 2021 · 15 comments
Closed

Remove unused feature flags #6140

mariusandra opened this issue Sep 28, 2021 · 15 comments
Labels
enhancement New feature or request feature/feature-flags Feature Tag: Feature flags team/feature-success

Comments

@mariusandra
Copy link
Collaborator

Is your feature request related to a problem?

Locally when developing and running python manage.py sync_feature_flags a lot of features get enabled, many of which we have abandoned a while ago.

Describe the solution you'd like

  • Go through each flag and figure out if we still need it. And if not, delete the relevant code.
  • test-environment-3149 is one such flag, but there are others at first glance.

Describe alternatives you've considered

Keep adding features until we run out of disk space.

Additional context

Thank you for your feature request – we love each and every one!

@mariusandra mariusandra added the enhancement New feature or request label Sep 28, 2021
@mariusandra
Copy link
Collaborator Author

test-environment-3149 is now deleted.

@paolodamico
Copy link
Contributor

paolodamico commented Oct 13, 2021

Did a pass today for #6401 and seems the remaining feature flags are needed. Posting an update here,

  • 3638-trailing-wau-mau & 5898-split-persons are waiting on some UX improvements.
  • ingestion-grid-exp-3 need input from @kpthatsme
  • I'm getting rid of project-home-exp-5 & releasing 112-ingestion-help-button
  • After this release I believe we can remove the feature flags for: 4267-event-property-taxonomy (@liyiy can you confirm), 4871-plugin-metrics & 5720-plugins-ui-jobs (@yakkomajuri can you confirm).
  • What do we want to do with horizontal funnels @alexkim205 @clarkus? 5730-funnel-horizontal-ui
  • In active use, everything else: cloud flags (Papercups, NPS, announcements), 3408-saved-insights, 5440-multivariate-support, hackathon-dive-dashboards, new-paths-ui, new-paths-ui-edge-weights, posthog-toolbar-feature-flags, 6050-remove-sessions, 5733-funnel-vertical-breakdown, 6063-rename-filters, correlation-analysis, sigma-analysis, 4141-event-columns

@pauldambra
Copy link
Member

4141-event-columns is still used. It's a relatively safe feature IMHO but still wrapped in the feature flag.

@alexkim205
Copy link
Contributor

alexkim205 commented Oct 13, 2021

5730-funnel-horizontal-ui is a FF that was blocked on new work around insight query building, but I feel like with the introduction of vertical breakdowns calling for more horizontal space, this feature became more relevant. I think there's still some validation to do here. Can we roll it out to a few users to get some feedback on this? Definitely happy to roll it back if there's user pushback

@yakkomajuri
Copy link
Contributor

Yeah we can get rid of 4871-plugin-metrics and 5720-plugins-ui-jobs

@paolodamico
Copy link
Contributor

I'll let @mariusandra pick the 5730-funnel-horizontal-ui flag as he'll be working on saved insights next sprint. Personally I'm an advocate of keeping the current vertical layout, but your approach of showing to some users and getting feedback seems reasonable. We can also do a proper A/B test where we track discoveries.

@Twixes
Copy link
Member

Twixes commented Nov 19, 2021

Looks like new-paths-ui is now rolled out to everyone (Cloud + self-hosted) – candidate for removal.

@alexkim205
Copy link
Contributor

new-sessions-player is also out to 100% of PostHog users so also be a candidate for removal

@mariusandra
Copy link
Collaborator Author

I think we're all living the turbo-mode by now.

@paolodamico
Copy link
Contributor

paolodamico commented Nov 19, 2021

Alright, I've removed Paths, new session player & correlation analysis. @mariusandra I think you can remove turbo-mode if it's ready. Here are the FFs we should decide what to do with:

  1. Horizontal funnels (5730-funnel-horizontal-ui) - @alexkim205 @clarkus what are we thinking? standardized horizontal layout in funnels or more convenient but not standardized vertical view? should we support both and let the user choose? change it based on screen width?
  2. Dive dashboards (hackathon-dive-dashboards) - @tiina303 what's the status of this? do we want to move forward? As it is today, the UX seems to be causing some confusion to users, so we might need to adjust first.
  3. Funnel vertical breakdown (5733-funnel-vertical-breakdown) - I believe this was a solid improvement but it had some bug, @alexkim205 @mariusandra what do we want to do with that one?
  4. Trailing WAU/MAU - it's released for everyone but we wanted to adjust the UI/UX before removing it. @clarkus any thoughts? One option was just to have a link in the docs that generates the graph automatically.
  5. Ingestion grid (ingestion-grid-exp-3) - I believe this was a successful experiment and while we may want to improve it, we could release it already. @kpthatsme ?

@tiina303
Copy link
Contributor

Dive dashboards (hackathon-dive-dashboards) - @tiina303 what's the status of this? do we want to move forward? As it is today, the UX seems to be causing some confusion to users, so we might need to adjust first.

Please see this issue: #5946 I was hoping core experience team could work on this as none of us who were on the team during the hackathon have expertise in this area.

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@mariusandra
Copy link
Collaborator Author

We should probably remove unused or released feature flags... 🤔

@neilkakkar
Copy link
Collaborator

indeed. An automated way is coming next month most probably! :)

@neilkakkar
Copy link
Collaborator

#16497

@posthog-bot posthog-bot removed the stale label Nov 27, 2023
@Twixes Twixes closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/feature-flags Feature Tag: Feature flags team/feature-success
Projects
None yet
Development

No branches or pull requests

9 participants