Reset button doesn't clear Compare Previous

[joethreepwood]

Bug description

I built a graph with 'compare previous' engaged to compare the previous 30 days. I pressed reset to clear all filters. The compare previous button didn't untick, but the information for the previous period did disappear from the graph. As a result, 'compare previous' seemed to be enabled but the information wasn't accurate. In order to get the correct information from the previous period I needed to disengage the 'compare previous' toggle, then re-engage.

Expected behavior

Pressing 'Reset' should either untick the compare previous box, or leave it check and include the relevant information.

How to reproduce

1. Build a query comparing a previous period.
2. Reset it.

Environment

• PostHog Cloud
• [x ] self-hosted PostHog (ClickHouse-based), version/commit: please provide
• self-hosted PostHog (Postgres-based, legacy), version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!

[samwinslow]

Not to hijack the issue, but for anyone looking at this — there's an additional minor issue related to Compare Previous right here: #5918

[pauldambra]

The UI has changed since this report. But also this seems to have been fixed in the nearly a year since it was reported