Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of materialized person columns in other insight features #5888

Closed
macobo opened this issue Sep 10, 2021 · 3 comments
Closed

Make use of materialized person columns in other insight features #5888

macobo opened this issue Sep 10, 2021 · 3 comments
Labels
enhancement New feature or request performance Has to do with performance. For PRs, runs the clickhouse query performance suite stale

Comments

@macobo
Copy link
Contributor

macobo commented Sep 10, 2021

Is your feature request related to a problem?

Person materialized columns are not always being used in all insights, instead an expensive subqueries are made for them.

Examples of this are Lifecycle, Stickiness, Retention insight features. Trends and funnels should work fine.

Describe the solution you'd like

Use materialized columns everywhere.

How to spot this in code: Look for calls to parse_prop_clauses without is_person_query or person_properties_column calls.

In those cases, use ColumnOptimizer to decide whether to join person table using ClickhousePersonQuery.

Describe alternatives you've considered

Additional context

Related: #5854

Thank you for your feature request – we love each and every one!

@macobo
Copy link
Contributor Author

macobo commented Nov 16, 2021

Stickiness added in #7117

Only lifecycle and sessions (deprecated) remain here + single events endpoint query

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Has to do with performance. For PRs, runs the clickhouse query performance suite stale
Projects
None yet
Development

No branches or pull requests

4 participants