Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for people with session recordings on persons modal #5173

Closed
liyiy opened this issue Jul 16, 2021 · 9 comments
Closed

Filter for people with session recordings on persons modal #5173

liyiy opened this issue Jul 16, 2021 · 9 comments
Labels
enhancement New feature or request feature/funnels Feature Tag: Funnels

Comments

@liyiy
Copy link
Contributor

liyiy commented Jul 16, 2021

Is your feature request related to a problem?

Please describe.

Users would like to see why persons are churning, etc. when looking at the persons modal for an insight. Allowing them to quickly filter for persons who have valid session recordings or only look at persons with session recordings could help them figure things out easier.

This will involve backend filtering for sessions with recordings for a specific person at that event and time, and then joining that with the person, which might make the persons query even slower? That is my understanding of how to make it work, but perhaps we have a better way I'm unaware of :D

BUT before that even, we should consider this in relation to #4884 first ! !

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

@liyiy liyiy added the enhancement New feature or request label Jul 16, 2021
@clarkus
Copy link
Contributor

clarkus commented Jul 16, 2021

This is the most recent design for the persons modal. The filters available are a keyword search that matches against names, email addresses, and IDs. Basically if you know a portion of the string you're looking for, this will help you find it that way. Secondarily there is a filter that reduces the set to only those entries with corresponding recordings.

Screen Shot 2021-07-16 at 11 13 35 AM

@paolodamico
Copy link
Contributor

I think this is independent of #4884 as the goal here is to take the user straight to a relevant session recording (session player page), so whatever we do with the sessions page won't affect this.

From what you said @liyiy, it sounds like we need some help from Core Analytics Team first, so transferring this issue to them. CC @EDsCODE

@macobo
Copy link
Contributor

macobo commented Jul 19, 2021

Thanks for writing this up!

Some considerations/questions:

  • @clarkus where would the show details lead?
  • How the back button should behave if user navigates off the page and back again is worth considering and writing down - whatever we do that's something users are gonna do a lot and determine the usefulness of this feature.
  • For this to work in e.g. funnels, we need to know "date" + "person" before filtering the session recording. This is slightly tricky in funnels:
    • If showing modal of dropped off, probably want to show recordings of step N-1 that they completed successfully!
    • If user completed steps multiple times, probably want to fetch the first date.
  • Technically the joining is not done in the same query but the same way recordings & sessions are joined - recordings are fetched second.

I think this is independent of #4884 as the goal here is to take the user straight to a relevant session recording (session player page), so whatever we do with the sessions page won't affect this.

Not sure that's the case (structural changes will affect this in large ways) but it's not necessarily a blocker. However things like session page being one-date only can affect this feature in very practical ways.

@clarkus
Copy link
Contributor

clarkus commented Jul 19, 2021

* @clarkus where would the show details lead?

The intent is to show the corresponding session and recording (if it exists). "View details" might not be the best label for the button here. Maybe "view session details" is more descriptive of the target?

* How the back button should behave if user navigates off the page and back again is worth considering and writing down - whatever we do that's something users are gonna do a _lot_ and determine the usefulness of this feature.

Given that there's a lot of analysis on each view, maybe we should consider opening in a new context. This is shown in a modal, so persisting that when we navigate back could feel cumbersome to users. This is a great point... I will spend more time thinking about ways to improve this.

However things like session page being one-date only can affect this feature in very practical ways.

Agree... any reason we're limited to a single date there?

@macobo
Copy link
Contributor

macobo commented Jul 21, 2021

Agree... any reason we're limited to a single date there?

No real product reason, but two pieces are missing:

Issue: #3471

@liyiy
Copy link
Contributor Author

liyiy commented Aug 5, 2021

Currently blocked by #5447

@macobo
Copy link
Contributor

macobo commented Aug 6, 2021

I don't think it is, the joining here would work in a different way 🤔

Also just noticed @clarkus' new design does not include a link to sessions page for all sessions anymore. Was that intentional?

Since this is a two-teamer (:disappointed:) and the communication barrier here is real, how about next sprint:

  1. Building out the UI under a flag (core-experience)
  2. Building out the backend support after that (core-analytics), removing the flag

@clarkus
Copy link
Contributor

clarkus commented Aug 9, 2021

Also just noticed @clarkus' new design does not include a link to sessions page for all sessions anymore. Was that intentional?

Unintentionally removed.

@pauldambra
Copy link
Member

you can do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/funnels Feature Tag: Funnels
Development

No branches or pull requests

5 participants