Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakdown by cohorts is confusing and/or buggy #4696

Closed
paolodamico opened this issue Jun 10, 2021 · 11 comments
Closed

Breakdown by cohorts is confusing and/or buggy #4696

paolodamico opened this issue Jun 10, 2021 · 11 comments
Labels
bug Something isn't working right feature/cohorts Feature Tag: Cohorts

Comments

@paolodamico
Copy link
Contributor

Is your feature request related to a problem?

Currently we support breaking down a trend graph by cohorts, but this presents a lot of confusion points:

  1. Feature is not easily discoverable and it's use is unclear. It takes a while to understand that you can select multiple cohorts to compare behavior for different cohorts. Is breakdown the right mental model for this?
    When you overcome the above, there's some weird behavior,
  2. See example of selecting two cohorts leading to no data. The test accounts filter should exclude "PostHog Team" but not "Real Users".
  3. Removing the test filter leads to numbers matching exactly, which is incorrect. While these cohorts are mutually exclusive, I would expect to see both graphed correctly.
  4. Another example of cohorts just matching data points exactly.
  5. We show cohort ID in places instead of the cohort name.

Describe the solution you'd like

Section above provides expectations of how this could potentially work.

Describe alternatives you've considered

Removing the ability to breakdown by cohorts?

Additional context

This is how He@p handles the concept of what on PostHog is "breaking down by cohorts".

Thank you for your feature request – we love each and every one!

@paolodamico paolodamico added bug Something isn't working right UI/UX labels Jun 10, 2021
@macobo
Copy link
Contributor

macobo commented Aug 6, 2021

As a bug it's a bit unclear what the desired action here is or if there are multiple bugs rolled into one.

(Or it might be late and my brain is not functioning)

Can we clarify this ticket a bit?

@paolodamico
Copy link
Contributor Author

Sorry let me clarify. Problem was that when doing breakdowns on a graph, we have the option to do breakdowns by cohorts. Yet, the experience of doing this is not intuitive. Is not clear what "breaking down by a cohort" is actually doing. Until you actually select multiple cohorts you understand what this is for.

All the above being said, @mariusandra did make a great improvement once you've added your first cohort (it says add cohort vs. being a multiselect). Outstanding problem is that it's not obvious that you can compare cohorts by adding a breakdown.

@macobo
Copy link
Contributor

macobo commented Aug 10, 2021

Ah nice! Given the current focus of the teams, I think this makes a bit more sense in core-experience backlog given extra design capacity? :)

@paolodamico
Copy link
Contributor Author

Definitely, the bugs scoped to Core Analytics seem to have been fixed now

@paolodamico
Copy link
Contributor Author

This has been improved but I still think we can improve discoverability of the feature. CC @clarkus

@clarkus
Copy link
Contributor

clarkus commented Nov 30, 2021

Some questions to clarify how this should be working:

  • It seems we can only breakdown by one property type at a given time. For example, I can't breakdown by a cohort and a person property simultaneously.
  • Cohorts are the only case for a multiple-select workflow in breakdowns.

Sound accurate, @paolodamico?

@clarkus
Copy link
Contributor

clarkus commented Nov 30, 2021

Here's a concept that changes "breakdowns" into a "group by" context. When grouping by cohorts, the user is presented with a multiple select. When grouping by any other property type, the user directly selects the property they want to group by. Scenarios in order of appearance: cohorts, persons, events, actions, groups, and lastly a placeholder. These wouldn't coexist, I'm just showing the variants we'd need to support.

Group by

https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-App?node-id=5569%3A33023

@paolodamico
Copy link
Contributor Author

  1. Yes, you can only breakdown either by cohorts or by properties.
  2. With the work @pauldambra is doing you will be able to add multiple breakdowns.
  3. Really like the new design, I think it definitely solves the problem. Only thing I'm unclear is how you would select whether to filter by cohorts, properties, ... in the first place? (i.e. the first dropdown that says "Cohorts")

@clarkus
Copy link
Contributor

clarkus commented Nov 30, 2021

  1. Yes, you can only breakdown either by cohorts or by properties.
  2. With the work @pauldambra is doing you will be able to add multiple breakdowns.
  3. Really like the new design, I think it definitely solves the problem. Only thing I'm unclear is how you would select whether to filter by cohorts, properties, ... in the first place? (i.e. the first dropdown that says "Cohorts")

Yeah I think we'll need some initial selection to scope the subsequent list of options. I've updated the designs to clarify.

Group by

https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-App?node-id=5569%3A33023

@pauldambra
Copy link
Member

With the work @pauldambra is doing you will be able to add multiple breakdowns.

Currently there's a single breakdown_type so even with multi breakdown (right now) once you have chosen event or cohort etc you can only select another property of the same type

We've started changing the API so that each breakdown property carries it's own type

e.g.

from {breakdown: "potato", breakdown_type: "fruit"}

to {breakdowns: [{property: "potato", type" fruit"}, {property: "tomato", type" color"}]}

but the underlying query assumes one breakdown_type still. In cutting scope I didn't figure out how to have multiple coexisting types

@paolodamico
Copy link
Contributor Author

The new taxonomic filter and UX for cohort breakdown solves this already 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/cohorts Feature Tag: Cohorts
Projects
None yet
Development

No branches or pull requests

4 participants