Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stickiness people "view sessions" button is broken #3472

Closed
2 tasks done
macobo opened this issue Feb 25, 2021 · 4 comments
Closed
2 tasks done

Stickiness people "view sessions" button is broken #3472

macobo opened this issue Feb 25, 2021 · 4 comments
Assignees
@liyiy
Labels
bug Something isn't working right feature/session-analytics feature/trends Feature Tag: Trends

Comments

@macobo
Copy link
Contributor

macobo commented Feb 25, 2021

Bug description

image

This link leads to sessions with the following filter:

image

Where the date filter is incorrect and the filter does not reflect

How to reproduce

  1. Go to trends > stickiness
  2. Click on a datapoint
  3. Click on view related sessions

Expected behavior

Unclear. Some options:

  1. Disable the link for stickiness
  2. Make the link filter by people/cohort instead (tricky)
  3. Make stickiness a top-level option for sessions filters (unclear on how this would work)

Related feature: making sessions date filters multi-day #3471

Environment

  • PostHog Cloud
  • self-hosted PostHog, version/commit: please provide

Additional context

If we wanted to support people modal in bar charts by value, we'd run into the same problem.

Thank you for your bug report – we love squashing them!
@macobo macobo added bug Something isn't working right feature/trends Feature Tag: Trends feature/session-analytics labels Feb 25, 2021
@macobo macobo mentioned this issue Feb 25, 2021
Merged
4 tasks
@macobo
Copy link
Contributor Author

macobo commented Feb 25, 2021

Similar problem in lifecycle graphs - while the links work well, they don't account for the lifecycle phase

@EDsCODE
Copy link
Member

EDsCODE commented Feb 26, 2021

Might be unrelated, but does this button work when remove-shownas feature flag is off?

@macobo
Copy link
Contributor Author

macobo commented Mar 26, 2021

Related: #3765

@liyiy liyiy self-assigned this Apr 20, 2021
@paolodamico
Copy link
Contributor

These buttons no longer exist, so we can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liyiy liyiy

Labels
bug Something isn't working right feature/session-analytics feature/trends Feature Tag: Trends
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@macobo @paolodamico @EDsCODE @liyiy