Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret keys in plugins #3082

Closed
mariusandra opened this issue Jan 25, 2021 · 4 comments
Closed

Secret keys in plugins #3082

mariusandra opened this issue Jan 25, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mariusandra
Copy link
Collaborator

Is your feature request related to a problem?

With plugins like the "github star sync plugin", I would like to give it my personal API key so it would get the data it needs, but I won't because then everyone in my team will see it and can read all my repositories.

image

There's a similar problem with auto generating personal API tokens in #2838 -- they should be "read once".

Describe the solution you'd like

I'd like a special configuration type secret (in addition to string and attachment), which would act as a "write-only" field.

Describe alternatives you've considered

Not leaking secret keys by not using the software.

Additional context

Thank you for your feature request – we love each and every one!

@yakkomajuri
Copy link
Contributor

Yeah had just opened another issue before seeing this. I think we can add another field to each config input rather than type, like private or secret. Can be edited but never viewed.

@Twixes
Copy link
Member

Twixes commented Jan 28, 2021

Something like "secret": true could be simple and versatile.

@yakkomajuri
Copy link
Contributor

yup

@Twixes
Copy link
Member

Twixes commented Mar 4, 2021

#3341 didn't entirely solve the security considerations regarding keeping secrets as secret as possible (encryption), but they're secret enough.

@Twixes Twixes closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants