Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session recording] clearly show which elements are being censored #2258

Closed
timgl opened this issue Nov 6, 2020 · 4 comments · Fixed by PostHog/posthog-js#328
Closed

[Session recording] clearly show which elements are being censored #2258

timgl opened this issue Nov 6, 2020 · 4 comments · Fixed by PostHog/posthog-js#328
Assignees
Labels
enhancement New feature or request

Comments

@timgl
Copy link
Collaborator

timgl commented Nov 6, 2020

Is your feature request related to a problem?

We censor certain elements from being recorded for privacy purposes which is great. However, every time I look at a recording I get a mini heart attack thinking the entire interface is broken.

Describe the solution you'd like

Would be good to just have a fake 'blurred data' in place of the censored element.

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

@timgl timgl added the enhancement New feature or request label Nov 6, 2020
@GalDayan
Copy link
Contributor

GalDayan commented Nov 7, 2020

Guys, it's really nice enhancement.
I just wondered, how did you recognize elements as "private elements" which you should censor them?
@timgl

@macobo
Copy link
Contributor

macobo commented Nov 7, 2020

@GalDayan We're using rrweb under the hood (https://github.com/rrweb-io/rrweb)

There's a guide here: https://github.com/rrweb-io/rrweb/blob/master/guide.md#privacy

I'm planning on making an upstream enhancement to include our own data attr for this.

cc @yakkomajuri

@yakkomajuri
Copy link
Contributor

@yakkomajuri
Copy link
Contributor

@macobo as for the issue itself, the best approach would be a PR upstream with some settings for what to display on censored elements.

The temp solution on our end could be to pass the list of censored elements on the page with the $snapshot event and display that to the user on the player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants