-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add documentation for autocapture custom labels for iOS #10085
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
** Adding a custom label in UIKit ** | ||
|
||
To assign a custom label to a UIView, use the `postHogLabel` property: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing the documentation made me wonder if it would be clearer to rename this to postHogIdentifier
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong opinion... but i think label more clearly says "something human readable" than identifier does
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment otherwise LGTM
Relates to PostHog/posthog-ios#271
Add documentation for custom label support for iOS autocapture