Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add documentation for autocapture custom labels for iOS #10085

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

ioannisj
Copy link
Contributor

@ioannisj ioannisj commented Dec 9, 2024

Relates to PostHog/posthog-ios#271

Add documentation for custom label support for iOS autocapture

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview Dec 9, 2024 3:19pm

@ioannisj ioannisj requested a review from a team December 9, 2024 06:18

** Adding a custom label in UIKit **

To assign a custom label to a UIView, use the `postHogLabel` property:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing the documentation made me wonder if it would be clearer to rename this to postHogIdentifier instead

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no strong opinion... but i think label more clearly says "something human readable" than identifier does

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment otherwise LGTM

@ioannisj ioannisj merged commit d2da1e5 into master Dec 10, 2024
3 checks passed
@ioannisj ioannisj deleted the feat/ios-autocapture-custom-label branch December 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants