Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging should have a prefix #149

Open
stanislavkozlovski opened this issue Nov 29, 2024 · 1 comment · May be fixed by #150
Open

Logging should have a prefix #149

stanislavkozlovski opened this issue Nov 29, 2024 · 1 comment · May be fixed by #150

Comments

@stanislavkozlovski
Copy link

Today, (in debug, since that's what I use) the library logs arbitrary stuff like:

consumer exited.

queueing: {'properties': {'..., '$lib': 'posthog-python', '$lib_version': '3.7.2', '$geoip_disable': True}, 'timestamp': '2024-11-29T13:25:36.143687+00:00', 'context': {}, 'distinct_id': '019362b1-37ca-7e98-bb6a-0c9c54c1b99a', 'event': '...'}

enqueued [event].

making request: {"batch": ..."}, "$lib": "posthog-python", "$lib_version": "3.7.2", "$geoip_disable": true}, "timestamp": "2024-11-29T13:25:36.143687+00:00", "context": {}, "distinct_id": "019362b1-37ca-7e98-bb6a-0c9c54c1b99a", "event": "..."}], "historical_migration": false, "sentAt": "2024-11-29T13:25:36.536523+00:00", "api_key": "..."}

data uploaded successfully

In any regular app, this is easy to confuse with the regular application logs. And more importantly - it's hard to tell apart when you want to debug posthog specifically.

It would be great if the logger had some set prefix.
@stanislavkozlovski
Copy link
Author

The way I get around this is through this method:

def fix_posthog_logging(posthog: Posthog):
    class PosthogClientLogPrefixFilter(logging.Filter):
        def filter(self, record):
            record.msg = f'[PostHog-Client] {record.msg}'
            return True
    for f in posthog.log.filters:
        if isinstance(f, PosthogClientLogPrefixFilter) or f.__class__.__name__ == 'PosthogClientLogPrefixFilter':
            return # it's already there!

    posthog.log.addFilter(PosthogClientLogPrefixFilter())

It's a bit inefficient re: the message append, and it's weird code because I have to double-check for the filter's presence to avoid adding it twice (something regarding Django initalization I guess)

@stanislavkozlovski stanislavkozlovski linked a pull request Nov 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MINOR: Set a prefix in the logger stanislavkozlovski/posthog-python
1 participant
@stanislavkozlovski