Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manually mask swiftui views #202

Merged
merged 12 commits into from
Oct 14, 2024
Merged

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 23, 2024

💡 Motivation and Context

Alternative solution for #162
You inject a synthetic view into the marked view and get the X and Y positions based on that component.
You don't have access to the original view but you know where it should be masked.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto
Copy link
Member Author

@ioannisj you can pick this up if you wish, the PoC works, just need to polish and finish it

@ioannisj ioannisj force-pushed the chore/swiftui-mask-manually branch from 5c49f80 to 1400e49 Compare October 10, 2024 09:12
@ioannisj
Copy link
Contributor

  • Updated relevant documentation under this PR
  • Replaced PostHogScreenshotMasker with an associated UIView property phIsManuallyMasked which is then grabbed during findMaskableWidgets call

@ioannisj ioannisj requested a review from a team October 10, 2024 09:49
@ioannisj ioannisj removed their request for review October 10, 2024 10:00
@ioannisj ioannisj marked this pull request as ready for review October 10, 2024 15:42
@marandaneto
Copy link
Member Author

@ioannisj I cannot approve my own PR so feel free to get it approved/merged after fixing the conflicts.

@ioannisj ioannisj merged commit 97ba160 into main Oct 14, 2024
6 checks passed
@ioannisj ioannisj deleted the chore/swiftui-mask-manually branch October 14, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants