Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: network logs not counting the request transferSize but only the response transferSize #193

Merged
merged 6 commits into from
Sep 12, 2024
Merged

recording: network logs not counting the request transferSize but only the response transferSize #193

merged 6 commits into from
Sep 12, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 12, 2024 •
edited
Loading

💡 Motivation and Context

Relates to PostHog/posthog-android#174

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review September 12, 2024 12:55
@marandaneto marandaneto requested a review from a team September 12, 2024 12:55
@marandaneto marandaneto changed the title recording: add missing starttime for network logs recording: network logs not counting the request transferSize buy only the response transferSize Sep 12, 2024
@marandaneto marandaneto changed the title recording: network logs not counting the request transferSize buy only the response transferSize recording: network logs not counting the request transferSize but only the response transferSize Sep 12, 2024
marandaneto
marandaneto commented Sep 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pauldambra
pauldambra approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto merged commit ef274d6 into main Sep 12, 2024
6 checks passed
@marandaneto marandaneto deleted the fix/starttime-networl-logs branch September 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @pauldambra @daibhin