fix: reduce batch size if API returns 413 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
pauldambra
approved these changes
May 8, 2024
Comment on lines
+334
to
+335
| config.maxBatchSize = calcFloor(config.maxBatchSize) | ||
| config.flushAt = calcFloor(config.flushAt) |
There was a problem hiding this comment.
nice... it makes me wonder how we'd know it was happening 🤔 but I guess we can figure out where we're returning 413 in capture and send an ingestion warning
There was a problem hiding this comment.
yeah we probably have 413s in our logging systems, adding one more custom event to the batch is likely to increase the payload :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Getting Flushing failed: PostHogApiError(statusCode=413, message=''). depending on the image size and batch size
💚 How did you test it?
Running and unit tests
📝 Checklist