From 0f1e883a1d629b570d846e9abb0d77c59b4007de Mon Sep 17 00:00:00 2001
From: sk-portkey <sai.t@portkey.ai>
Date: Sat, 9 Nov 2024 03:37:37 +0530
Subject: [PATCH] fix: conditional mysql root password omnly for internal

---
 charts/portkey-app/templates/_helpers.tpl | 2 ++
 charts/portkey-app/values.yaml            | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/charts/portkey-app/templates/_helpers.tpl b/charts/portkey-app/templates/_helpers.tpl
index 0aa847e..e0e3ebe 100644
--- a/charts/portkey-app/templates/_helpers.tpl
+++ b/charts/portkey-app/templates/_helpers.tpl
@@ -216,11 +216,13 @@ Template containing common environment variables that are used by several servic
     secretKeyRef:
       name: {{ include "portkey.mysqlSecretsName" . }}
       key: mysql_password
+{{ if not .Values.mysql.external.enabled }}
 - name: MYSQL_ROOT_PASSWORD
   valueFrom:
     secretKeyRef:
       name: {{ include "portkey.mysqlSecretsName" . }}
       key: mysql_root_password
+{{- end }}
 
 {{- if .Values.config.oauth.enabled }}
 - name: AUTH_MODE
diff --git a/charts/portkey-app/values.yaml b/charts/portkey-app/values.yaml
index 6b79313..71255e8 100644
--- a/charts/portkey-app/values.yaml
+++ b/charts/portkey-app/values.yaml
@@ -506,7 +506,7 @@ redis:
     connectionUrl: ""
     tlsEnabled: ""
     mode: ""
-    store: ""
+    store: "redis"
     existingSecretName: ""
   containerPort: 6379
   statefulSet: