Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw more exceptions on audit.addRequest #101

Open
floyd-fuh opened this issue Sep 5, 2024 · 3 comments
Open

Throw more exceptions on audit.addRequest #101

floyd-fuh opened this issue Sep 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@floyd-fuh
Copy link
Contributor

Hi there,

Could you add more exceptions that are thrown (e.g. IllegalArgumentException) when somebody tries the following (Kotlin):

val audit = api.scanner().startAudit(AuditConfiguration.auditConfiguration(BuiltInAuditConfiguration.LEGACY_ACTIVE_AUDIT_CHECKS))
audit.addRequest(HttpRequest.httpRequest("GET / HTTP/1.1\r\nHost: ginandjuice.shop"))

Because the HttpRequest will always be missing an HTTPService and the scanner is then just mainly timing out...

@Hannah-PortSwigger
Copy link
Contributor

Not having a service on an HttpRequest does catch people out fairly regularly - would improving the general error message when trying to do network operations on requests without a service attached align with what you are looking for?

@floyd-fuh
Copy link
Contributor Author

I'm talking about the Montoya API here, so I would appreciate if the API would actually throw a Java exception.

As to the Repeater UI etc. I'm fine if the general error message would be improved

@Hannah-PortSwigger
Copy link
Contributor

Thanks for the feedback! I've got that feature request raised.

It will need to be prioritized and weighed against other feature requests and improvements, so I can't provide you with any timescales.

If there's anything else we can help with, then please let us know.

@Hannah-PortSwigger Hannah-PortSwigger added the enhancement New feature or request label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants