Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement : CLS Compatibility #991

Closed
mwerle opened this issue May 2, 2022 · 2 comments
Closed

Improvement : CLS Compatibility #991

mwerle opened this issue May 2, 2022 · 2 comments

Comments

@mwerle
Copy link

mwerle commented May 2, 2022

Restock changes the visuals of several stock parts to include additional hatches compared to the stock visuals.

A user has supplied a patch to CLS for the affected ReStock parts, however, there's an argument to be made that this patch would be better shipped with ReStock. This would allow ReStock authors to keep the CLS patch up-to-date with any future artwork changes.

Thoughts?

The patch: codepoetpbowden/ConnectedLivingSpace@cc9cf30

The original issue: codepoetpbowden/ConnectedLivingSpace#117

@Poodmund
Copy link
Collaborator

Poodmund commented May 2, 2022

There is unlikely to ever be any future artwork changes to the mod and patches already exist within CLS to work with ReStock (codepoetpbowden/ConnectedLivingSpace#113) so I think it would be better for it to be handled within CLS as there's likely going to be more active development and more frequent releases to handle these issues.

As an addendum, ReStock also causes issues with CLS due to the part variant system, see #959

@mwerle
Copy link
Author

mwerle commented May 3, 2022

Thanks for your reply and feedback. So we'll continue to support ReStock (and ReStock+) directly within CLS.

@mwerle mwerle closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants