Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to catch syntax errors in the Click Open popup trigger Extra Selectors input field #993

Open
marklchaves opened this issue Mar 23, 2022 · 0 comments

Comments

@marklchaves
Copy link
Contributor

marklchaves commented Mar 23, 2022

Describe the feature request

It'd be great to add some form validation for CSS syntax checking when adding extra CSS selectors to a Click Open trigger.

Use case

If I add a[href="https://twenty-twentyone.local/ " it will get saved with no issues, but the popup won't trigger unless the same syntax error is in the calling HTML. (Note: The example has a blank space before the closing double quote and is missing a closing bracket.)

When I use the Popup Maker admin toolbar to open the popup or click anywhere on the page that has the popup loaded, I'll see an exception in the console. See below.

If we are able to validate the syntax or even generate the correct syntax behind the scenes, this would prevent manual typing and syntax errors, especially for the Link Presets feature.

Example screenshots (if any)

Exception in the browser console: https://share.wppopupmaker.com/2NuzJL1P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant