Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React pose stutter / performance issues #717

Closed
thevisualfox opened this issue Jan 28, 2019 · 3 comments
Closed

React pose stutter / performance issues #717

thevisualfox opened this issue Jan 28, 2019 · 3 comments
Labels
Pose is deprecated React Pose users can upgrade to Framer Motion: https://framer.com/motion

Comments

@thevisualfox
Copy link

Using the lastes version of react-pose ( 4.0.6 )

Currently, when PoseGroup triggers leave animations, it removes the animating element from the DOM once that animation is finished.

The problem is that when lots of other animations are still animating, this React reconciliation stutters.

Steps to reproduce the behavior:

  1. Go to https://codepen.io/anon/pen/mKEzVp?editors=0010
  2. Watch how the animation stutters

I've read that the onRest prop should fix this, but I'm not sure how to implement this.
This is prominent across all browsers!

I hope this could get fixed, or if I'm doing something wrong, someone could correct me!

Cheers.

@Andarist
Copy link
Contributor

I've started looking into this problem, leaving a "simplified" version of your code here - https://codesandbox.io/s/pp24p7q720 for a reference.

@jontro
Copy link

jontro commented Feb 3, 2019

When upgrading to 4.0.6 from 4.0.4 I've started experiencing performance issues when the onExit animation triggers in combination with inserting new elements in the PoseGroup. It might be related to this fix #682

@robbeman
Copy link

I came across this issue because I experienced the same, but then I noticed the following:

React Pose has been deprecated in favour of Framer Motion

(See https://github.com/Popmotion/popmotion/tree/master/packages/react-pose) You might want to check that out, it looks like a nice way to go if your project is not too big to migrate.

@mattgperry mattgperry added the Pose is deprecated React Pose users can upgrade to Framer Motion: https://framer.com/motion label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pose is deprecated React Pose users can upgrade to Framer Motion: https://framer.com/motion
Projects
None yet
Development

No branches or pull requests

5 participants