Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Arrow keys move slider and scroll the page #161

Open
stevenjb opened this issue Jan 9, 2017 · 1 comment
Open

Arrow keys move slider and scroll the page #161

stevenjb opened this issue Jan 9, 2017 · 1 comment

Comments

@stevenjb
Copy link
Contributor

stevenjb commented Jan 9, 2017

Description

Pressing up/down/left/right will change the slider value but will also scroll the screen.

Expected outcome

The page should not scroll. Other elements (e.g. up/down in paper-listbox) do not do this.

Actual outcome

The page scrolls (when scrollable, e.g. when the window is small).

Live Demo

This can be seen by making the browser window for the paper-slider demo page small:
https://elements.polymer-project.org/elements/paper-slider?view=demo:demo/index.html&active=paper-slider
@stevenjb stevenjb changed the title Arrow keys move slider and scroll page Arrow keys move slider and scroll the page Jan 9, 2017
stevenjb added a commit to stevenjb/paper-slider that referenced this issue Jan 17, 2017
@stevenjb
stopPropagation in increment/decrementKey
618e026 
Fix for issue PolymerElements#161 - Arrow keys move slider and scroll the page
@stevenjb stevenjb mentioned this issue Jan 17, 2017
Closed
stevenjb added a commit to stevenjb/paper-slider that referenced this issue Jan 17, 2017
@stevenjb
Prevent arrow keys from scrolling page
53e59f9 
Actual tested fix for issue PolymerElements#161 to prevent keys from scrolling the page in paper-slider.
stevenjb added a commit to stevenjb/paper-slider that referenced this issue Jan 18, 2017
@stevenjb
Prevent arrow keys from scrolling page
42d64f7 
Actual tested fix for issue PolymerElements#161 to prevent keys from scrolling the page in paper-slider.
@stevenjb stevenjb mentioned this issue Jan 18, 2017
Merged
@stevenjb
Copy link
Contributor Author

Apologies for all of the churn above, but I believe that pull request #165 is correct (or at least works for me).

keanulee pushed a commit that referenced this issue Jan 20, 2017
@stevenjb @keanulee
Prevent arrow keys from scrolling page (#165)
cb04045 
* Prevent arrow keys from scrolling page

Actual tested fix for issue #161 to prevent keys from scrolling the page in paper-slider.

* Add tests for up/down keys
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevenjb