From 867a7962e632d6c5aec4b1b09be937e051dda206 Mon Sep 17 00:00:00 2001 From: PavelMakarchuk Date: Wed, 15 Nov 2023 21:29:03 +0100 Subject: [PATCH 1/2] Duplicate Ohio income tax parameter name deductions Fixes #3270 --- changelog_entry.yaml | 4 +++ .../gov/states/oh/tax/income/deductions.yaml | 23 ---------------- .../oh/tax/income/deductions/deductions.yaml | 27 ++++++++++++------- .../states/ky/tax/income/ky_filing_status.py | 2 +- .../oh/tax/income/deductions/oh_deductions.py | 2 +- 5 files changed, 24 insertions(+), 34 deletions(-) delete mode 100644 policyengine_us/parameters/gov/states/oh/tax/income/deductions.yaml diff --git a/changelog_entry.yaml b/changelog_entry.yaml index e69de29bb2d..c3eefeff48d 100644 --- a/changelog_entry.yaml +++ b/changelog_entry.yaml @@ -0,0 +1,4 @@ +- bump: patch + changes: + fixed: + - Duplicate Ohio income tax parameter name deductions. diff --git a/policyengine_us/parameters/gov/states/oh/tax/income/deductions.yaml b/policyengine_us/parameters/gov/states/oh/tax/income/deductions.yaml deleted file mode 100644 index 21fc049839e..00000000000 --- a/policyengine_us/parameters/gov/states/oh/tax/income/deductions.yaml +++ /dev/null @@ -1,23 +0,0 @@ -description: Ohio deducts these sources from the federal adjusted gross income. -values: - 2021-01-01: - - oh_section_179_expense_add_back - - qualified_business_income_deduction - - tax_unit_taxable_social_security - - dividend_income - # - above_the_line_deductions" #only need line 8z - - oh_uniformed_services_retirement_income_deduction - - investment_in_529_plan - - spm_unit_pell_grant - - educator_expense - - disability_benefits -metadata: - unit: list - label: Ohio deductions - reference: - - title: 2022 Individual Income Tax - Ohio - href: https://tax.ohio.gov/static/communications/publications/individual_income_tax_ohio.pdf#page=2 - - title: 2022 Ohio Schedule of Adjustments - href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2022/it1040-bundle.pdf#page=3 - - title: 20XX Ohio IT 1040 Individual Income Tax Return - href: https://cms7files1.revize.com/starkcountyoh/Document_center/Offices/Auditor/Services/Homestead%20Exemption/Ohio_Adj_Gross_Income.pdf#page=1 diff --git a/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml b/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml index 53b6422bc0e..3d48022ab3c 100644 --- a/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml +++ b/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml @@ -1,15 +1,24 @@ -description: Ohio allows for these deductions from taxable income. +description: Ohio deducts these sources from the federal adjusted gross income. values: 2021-01-01: + - oh_section_179_expense_add_back + - qualified_business_income_deduction + - tax_unit_taxable_social_security + - dividend_income + # - above_the_line_deductions" #only need line 8z + - oh_uniformed_services_retirement_income_deduction - oh_529_plan_deduction + - spm_unit_pell_grant + - educator_expense + - disability_benefits + metadata: unit: list - period: year - label: Ohio taxable income deductions + label: Ohio deductions reference: - - title: Ohio 2021 Instructions for Filing Original and Amended - href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2021/pit-it1040-booklet.pdf - - title: Ohio 2022 Tax Form - href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2022/it1040-sd100-instruction-booklet.pdf#page=14 - - title: Ohio Revised Code, Title 57 Taxation, Chapter 5747 Income Tax, Section 5747.01 - href: https://law.justia.com/codes/ohio/2022/title-57/chapter-5747/section-5747-01/ + - title: 2022 Individual Income Tax - Ohio + href: https://tax.ohio.gov/static/communications/publications/individual_income_tax_ohio.pdf#page=2 + - title: 2022 Ohio Schedule of Adjustments + href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2022/it1040-bundle.pdf#page=3 + - title: 20XX Ohio IT 1040 Individual Income Tax Return + href: https://cms7files1.revize.com/starkcountyoh/Document_center/Offices/Auditor/Services/Homestead%20Exemption/Ohio_Adj_Gross_Income.pdf#page=1 diff --git a/policyengine_us/variables/gov/states/ky/tax/income/ky_filing_status.py b/policyengine_us/variables/gov/states/ky/tax/income/ky_filing_status.py index 5d692d8b936..e33c2cab340 100644 --- a/policyengine_us/variables/gov/states/ky/tax/income/ky_filing_status.py +++ b/policyengine_us/variables/gov/states/ky/tax/income/ky_filing_status.py @@ -15,7 +15,7 @@ class ky_filing_status(Variable): definition_period = YEAR reference = ( "https://codes.findlaw.com/ky/title-xi-revenue-and-taxation/ky-rev-st-sect-141-066.html", # Section (1), (c) & (d) - "https://revenue.ky.gov/Forms/740%20Packet%20Instructions%205-9-23.pdf#page=11" + "https://revenue.ky.gov/Forms/740%20Packet%20Instructions%205-9-23.pdf#page=11", ) label = "Filing status for the tax unit in Kentucky" defined_for = StateCode.KY diff --git a/policyengine_us/variables/gov/states/oh/tax/income/deductions/oh_deductions.py b/policyengine_us/variables/gov/states/oh/tax/income/deductions/oh_deductions.py index e0f3038f424..def7ae02bef 100644 --- a/policyengine_us/variables/gov/states/oh/tax/income/deductions/oh_deductions.py +++ b/policyengine_us/variables/gov/states/oh/tax/income/deductions/oh_deductions.py @@ -13,4 +13,4 @@ class oh_deductions(Variable): "https://cms7files1.revize.com/starkcountyoh/Document_center/Offices/Auditor/Services/Homestead%20Exemption/Ohio_Adj_Gross_Income.pdf" ) defined_for = StateCode.OH - adds = "gov.states.oh.tax.income.deductions" + adds = "gov.states.oh.tax.income.deductions.deductions" From b4d4e30f8efd1b39144da1d8bca60623c16b0784 Mon Sep 17 00:00:00 2001 From: PavelMakarchuk Date: Wed, 15 Nov 2023 21:30:10 +0100 Subject: [PATCH 2/2] references --- .../states/oh/tax/income/deductions/deductions.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml b/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml index 3d48022ab3c..6faa2cf3f75 100644 --- a/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml +++ b/policyengine_us/parameters/gov/states/oh/tax/income/deductions/deductions.yaml @@ -16,9 +16,9 @@ metadata: unit: list label: Ohio deductions reference: - - title: 2022 Individual Income Tax - Ohio - href: https://tax.ohio.gov/static/communications/publications/individual_income_tax_ohio.pdf#page=2 - - title: 2022 Ohio Schedule of Adjustments - href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2022/it1040-bundle.pdf#page=3 - - title: 20XX Ohio IT 1040 Individual Income Tax Return - href: https://cms7files1.revize.com/starkcountyoh/Document_center/Offices/Auditor/Services/Homestead%20Exemption/Ohio_Adj_Gross_Income.pdf#page=1 + - title: Ohio 2021 Instructions for Filing Original and Amended + href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2021/pit-it1040-booklet.pdf + - title: Ohio 2022 Tax Form + href: https://tax.ohio.gov/static/forms/ohio_individual/individual/2022/it1040-sd100-instruction-booklet.pdf#page=14 + - title: Ohio Revised Code, Title 57 Taxation, Chapter 5747 Income Tax, Section 5747.01 + href: https://law.justia.com/codes/ohio/2022/title-57/chapter-5747/section-5747-01/