Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the outputs to reflect states without state income tax #166

Open
noman404 opened this issue Dec 28, 2024 · 5 comments · May be fixed by #172
Open

Adjust the outputs to reflect states without state income tax #166

noman404 opened this issue Dec 28, 2024 · 5 comments · May be fixed by #172
Assignees
@noman404

Comments

@noman404
Copy link
Collaborator

noman404 commented Dec 28, 2024 •
edited
Loading

As special cases are growing and more states requires to skip variable calls, they needs to be optimized and generalized. As discussing here

@noman404 noman404 self-assigned this Dec 28, 2024
@noman404 noman404 mentioned this issue Dec 29, 2024
Open
@PavelMakarchuk
Copy link
Collaborator

Is this geared towards states without state income taxes - if so we should name the issue that way

@noman404
Copy link
Collaborator Author

Right, this to more to cover the special cases for the states does not have that as well as if any other scenarios related to the state related calculation

noman404 added a commit to noman404/policyengine-taxsim that referenced this issue Dec 29, 2024
@noman404
remove tx from this PR to move into PolicyEngine#166
e0a9329
@PavelMakarchuk
Copy link
Collaborator

Right, this to more to cover the special cases for the states does not have that as well as if any other scenarios related to the state related calculation

Lets keep this issue just to states without state income tax for simplicity

@PavelMakarchuk PavelMakarchuk changed the title Improve YAML structure for special cases Adjust the outputs to reflect states without state income tax Dec 29, 2024
@MaxGhenis
Copy link
Contributor

as if any other scenarios related to the state related calculation

such as?

@noman404
Copy link
Collaborator Author

noman404 commented Dec 30, 2024 •
edited
Loading

For now they are TX, FL, NV, WY, etc and also the n/a cases in excel list which are not implemented right now.

@noman404 noman404 linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noman404 noman404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added special cases for state_income_tax noman404/policyengine-taxsim
3 participants
@noman404 @MaxGhenis @PavelMakarchuk