Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting SALT deduction to zero #160

Open
feenberg opened this issue Dec 19, 2024 · 9 comments · May be fixed by #171
Open

Setting SALT deduction to zero #160

feenberg opened this issue Dec 19, 2024 · 9 comments · May be fixed by #171
Labels
Backlog Future Development

Comments

@feenberg
Copy link

I want to set the SALT maximum deduction to zero in the emulator. I can do this in Taxsim and it makes testing itemized deductions much easier (when mortgage is recognized). I looked for the file

/policyengine_us/parameters/gov/irs/deductions/itemized/salt_and_real_estate/cap.yaml

but I can't even find policyengine_us, in spite of the fact that it is clearly working.

If SALT is deducted on the federal return, it makes for confusion when diagnosing problems in states that allow a federal deduction. When working with Martin we always turned this off.

@PavelMakarchuk
Copy link
Collaborator

PavelMakarchuk commented Dec 19, 2024

Could we have an option to set the salt_deduction variable to 0 if needed? Instead of adjusting the parameter value @noman404 @MaxGhenis

@feenberg
Copy link
Author

An option would be fine, but I could start testing itemization right away if I knew the location of the variable and it seems a shame to make an option just for this one variable when there is a general purpose system in place that will work for any variable (if I knew how to use it).

@MaxGhenis
Copy link
Contributor

The variable is salt_deduction; you can set it to zero as you would set other input variables to their values.

@noman404 noman404 linked a pull request Jan 2, 2025 that will close this issue
@MaxGhenis
Copy link
Contributor

@feenberg: How do you specify in the taxsim CLI whether to skip SALT? We'd like to mirror the interface in the emulator.

@feenberg
Copy link
Author

feenberg commented Jan 2, 2025 via email

@feenberg
Copy link
Author

feenberg commented Jan 2, 2025 via email

@MaxGhenis
Copy link
Contributor

OK since we don't do the iteration we don't have an exact analog, so it seems like we should proceed with this solution. Dan, if you add a less taxsim-implementation-specific taxsim CLI arg to zero out the SALT deduction in the future, we can emulate that instead. You could also adopt the standard in #171 of --disable-salt.

@noman404 noman404 added the Backlog Future Development label Jan 5, 2025
@PavelMakarchuk
Copy link
Collaborator

@feenberg are we aiming to disable just the federal state and local tax deduction or also the state equivalents, if present?

@feenberg
Copy link
Author

feenberg commented Jan 6, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Future Development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants