Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calculating impacts of structural reforms, the line in the varying your earnings chart is not correct #287

Closed
PavelMakarchuk opened this issue Aug 11, 2024 · 10 comments · Fixed by #288
Labels
bug Something isn't working

Comments

@PavelMakarchuk
Copy link
Collaborator

This seems to appear sporadically and only when returning to the chart multiple times

image

@PavelMakarchuk PavelMakarchuk added the bug Something isn't working label Aug 11, 2024
@PavelMakarchuk PavelMakarchuk changed the title When calculating impacts of structural reforms, the line and dot in the varying your earnings chart does not align When calculating impacts of structural reforms, the line in the varying your earnings chart is not correct Aug 11, 2024
@PavelMakarchuk
Copy link
Collaborator Author

The dot seems to be correct

@MaxGhenis
Copy link
Contributor

Could you drop the link? Could it be that it's missing a neutralization?

@PavelMakarchuk
Copy link
Collaborator Author

Example 1

Example 2

@anth-volk
Copy link
Contributor

This sounds a lot like PolicyEngine/policyengine-app#1079.

@anth-volk
Copy link
Contributor

Did some looking into this. It does appear to be missing some sort of neutralization, though unclear what exactly at the moment. This is visible if checking out a couple different panels in "Example 1" above. Here are some screenshots with commentary:

Screen Shot 2024-09-14 at 12 27 54 AM Screen Shot 2024-09-14 at 12 30 42 AM

@anth-volk
Copy link
Contributor

Definitely still an issue post -us-data changes

@anth-volk
Copy link
Contributor

Turns out the line is likely correct, not the dot

@MaxGhenis
Copy link
Contributor

Could there be a year mismatch?

@anth-volk anth-volk transferred this issue from PolicyEngine/policyengine-app Oct 5, 2024
@anth-volk
Copy link
Contributor

Transferred from -app as the bug causing this lies in -core.

@anth-volk
Copy link
Contributor

The best place to create a test would actually be the API, as reproducing requires multiple runs and a CountryTaxBenefitSystem instance, hence the issue opened to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants