Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't need to set the API KEY? #36

Open
syntag opened this issue Oct 11, 2023 · 2 comments
Open

Don't need to set the API KEY? #36

syntag opened this issue Oct 11, 2023 · 2 comments

Comments

@syntag
Copy link

syntag commented Oct 11, 2023

Docs mention that we need to create an API key and set it to POKEMONTCG_API_KEY in .env file. However, PokemonTCG does not seem to read this at all - and is working without adding any key. Don't think this is expected.

@sladesamuel
Copy link

@syntag I'm just starting out with this SDK, but noticed the same thing. Looking at the code, the POKEMONTCG_API_KEY env var is read internally. However, the docs mention that an API Key is not required to hit the API. But not specifying an API Key will result in much more restrictive rate limiting, so it's recommended to register for an API Key for better rate limits (source).

@syntag
Copy link
Author

syntag commented Jan 11, 2025

But not specifying an API Key will result in much more restrictive rate limiting, so it's recommended to register for an API Key for better rate limits (source).

@sladesamuel Ah good find. Thanks for sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants