Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Change? #6060

Closed
camnomis opened this issue Jun 24, 2017 · 10 comments
Closed

API Change? #6060

camnomis opened this issue Jun 24, 2017 · 10 comments

Comments

@camnomis
Copy link

[2017-06-24 16:10:44] [PokemonGoBot] [INFO] Niantic Official API Version: 0.67.1
[2017-06-24 16:10:44] [PokemonGoBot] [INFO] Latest Bossland Hashing API Version: 0.67.1
[2017-06-24 16:10:44] [PokemonGoBot] [INFO] We have detected a Pokemon API Change. Latest Niantic Version is: 0.67.1. Program Exiting...

I thought when bossland changed "we" had a fix where as the API version being checked against wasn't hardcoded?

@walaoaaa1234
Copy link
Contributor

walaoaaa1234 commented Jun 24, 2017

@camnomis
pgoapi not yet updated, hashing server does updated the algorithm. just wait more couple day, and the request flow changed, need more days on request.

@MerlionRock
Copy link
Contributor

We check against what API we are using. Bossland is already providing latest hashing but Python API not ready. They want to be sure no trap set by Niantic before releasing it.

We will wait for them.

(I know what need to be done to implement the API change, but I'm not going to do it)

@corneliu-iancu
Copy link

Any news on this api change?

@walaoaaa1234
Copy link
Contributor

pgoapi is updated, the bot haven't update the request flow.
you may run the bot now, but your account may flagged/BANNED/slash pokemon.
If you persist, run pip install -r requirements.txt -U
If you don't know what it is, DO NOT RUN THE BOT

@davidakachaos
Copy link
Contributor

Sniping is the main issue for getting flagged Pokemon I think...

@pogarek
Copy link
Contributor

pogarek commented Jun 29, 2017

ok, we got some PRs about new api, but I don't think is enough. We need to remember about Get_Inbox in requests.

RocketMap got updated: RocketMap/RocketMap@a125ebd

but we have some problems here

  1. some say, that get_inbox should on every request and some says, that only on few
  2. in bot sometimes we use functions from api_wrapper, and sometime we call api directly. For example check .py files for get_buddy_walked
  3. In POgoLib (C#) the api handles default requests https://github.com/AeonLucid/POGOLib/blob/7357c56279f964e25e660e42367fbd140dd1f9fd/POGOLib.Official/Net/RpcClient.cs#L323 , so every request there is CheckChallenge , GetHatchedEggs, GetInventory , CheckAwardedBadges,DownloadSettings . Getinbox will be added there as well , probably
  4. so we shoudl have ALL request handled by one code in bot or in api.
  5. let's take check_awarded_badges now. In bot we call it only in heartbeat (init.py).

to much unknowns here for me.. plus my low python experience excludes me from fixing the bot..

@walaoaaa1234
Copy link
Contributor

walaoaaa1234 commented Jun 29, 2017

#6057
maybe we can use sLoPPydrive MrMime.
https://github.com/sLoPPydrive/MrMime/
but is everyone using the correct request flow?

@davidakachaos
Copy link
Contributor

@MerlionRock has fixed the checking of the API and I have implemented GetInbox in heartbeat, I don't know if it's enough though...

@goedzo
Copy link
Contributor

goedzo commented Jul 20, 2017

Please close issue. Is fixed now.

@davidakachaos
Copy link
Contributor

Closing this issue, if you think this is an error please let us know! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants