Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] pinap on low lvl mons #5986

Closed
WayneUong opened this issue Mar 30, 2017 · 6 comments
Closed

[Feature Request] pinap on low lvl mons #5986

WayneUong opened this issue Mar 30, 2017 · 6 comments

Comments

@WayneUong
Copy link

Can we have pinap_on_level_below or pinap_on_cp_below options?

@MerlionRock
Copy link
Contributor

My hash key expired.

Once I have a vaild hash key, I'll work on it. That's not hard.

@MerlionRock
Copy link
Contributor

This option is for use_pinap_on_vip right?

Doesn't make sense if anyone want to use on any other pokemon that's not VIP....

@davidakachaos
Copy link
Contributor

I disagree Merlion, Maybe someone wants to use a pinap on a Pokemon when they can almost evolve that Pokemon in a missing or better combat Pokemon.

I vote for a pinap_on_candy_needed kind of config.

@MerlionRock
Copy link
Contributor

I've added 3 new configuration, they are:

"pinap_on_level_below": 0,
"pinap_operator": "or",
"pinap_ignore_threshold": false,

set "pinap_on_level_below" to 0 if you don't want to use it at all
"pinap_operator" -> or | and to be used together with "use_pinap_on_vip"
"pinap_ignore_threshold" to ignore threshold if set to true

Any more request before I sumbit a PR?

@MerlionRock
Copy link
Contributor

PR added #5990

@MerlionRock
Copy link
Contributor

Merged therefore Close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants