-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgoapi code change is in conflict with bot and virtuaenv #5868
Comments
Waiting for someone from @PokemonGoF/pokemongo-bot-team to check this. |
Check this patch: pogodevorg/pgoapi@bd87ce2 |
Ok, so basing on PokemonGo-Map I tested the approach and it worked (for me, in virtualenv). However it requires some manual actions (for upgrade) and I'm not sure how to do the commit/PR, to make users aware /implement the changes for them. Steps to be done : (first make sure that you have updated your repo by using 'git pull' . At the moment of writing this comment, master branch is the most updated)
then edit requirements.txt (in root of the bot) and:
then start the bot., So far, so good. And bots uses the latest pogoapi now. If above will work for everyone, then PR would need to have:
|
This issue affects the combination of bot+virtualenv+latets pogoapi from dev.
I've have checked PokemonGo-Map with latest pogoapi (I've changed their requirementst.txt) and with virtualenv and map works.
In this commit pogodevorg/pgoapi@d5f846a, they changed support for protobuf3-to-dict:
to:
This breaks the bot ability to login while running under virtualenv.
However I don't know how to fix it.
The text was updated successfully, but these errors were encountered: