Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgoapi code change is in conflict with bot and virtuaenv #5868

Closed
pogarek opened this issue Jan 12, 2017 · 3 comments
Closed

pgoapi code change is in conflict with bot and virtuaenv #5868

pogarek opened this issue Jan 12, 2017 · 3 comments

Comments

@pogarek
Copy link
Contributor

pogarek commented Jan 12, 2017

This issue affects the combination of bot+virtualenv+latets pogoapi from dev.
I've have checked PokemonGo-Map with latest pogoapi (I've changed their requirementst.txt) and with virtualenv and map works.

In this commit pogodevorg/pgoapi@d5f846a, they changed support for protobuf3-to-dict:

  • They require version higher or equal to >=0.1.4 and they did some code change,
  • They have removed protobuf_to_dict.py file and switched to the one from requirements
  • They have changed rpc_api.py from:
[auth_ticket['expire_timestamp_ms'], base64.standard_b64decode(auth_ticket['start']), base64.standard_b64decode(auth_ticket['end'])])  

to:

[auth_ticket['expire_timestamp_ms'], auth_ticket['start'], auth_ticket['end']]) 

This breaks the bot ability to login while running under virtualenv.

However I don't know how to fix it.

@pogarek
Copy link
Contributor Author

pogarek commented Jan 12, 2017

Waiting for someone from @PokemonGoF/pokemongo-bot-team to check this.

@Jcolomar
Copy link
Contributor

Jcolomar commented Jan 14, 2017

Check this patch: pogodevorg/pgoapi@bd87ce2

@pogarek
Copy link
Contributor Author

pogarek commented Jan 18, 2017

Ok, so basing on PokemonGo-Map I tested the approach and it worked (for me, in virtualenv). However it requires some manual actions (for upgrade) and I'm not sure how to do the commit/PR, to make users aware /implement the changes for them.

Steps to be done : (first make sure that you have updated your repo by using 'git pull' . At the moment of writing this comment, master branch is the most updated)

pip uninstall pgoapi
pip uninstall protobuf_to_dict
pip uninstall protobuf3-to-dict

then edit requirements.txt (in root of the bot) and:

  1. remove the line with: protobuf==3.0.0b4
  2. remove the line with: protobuf-to-dict==0.1.0
  3. change line with pogoapi to:

git+https://github.com/pogodevorg/pgoapi.git@develop#egg=pgoapi

  1. run:

pip2 install --upgrade -r requirements.txt

then start the bot., So far, so good. And bots uses the latest pogoapi now.

If above will work for everyone, then PR would need to have:

  1. updated requirements.txt
  2. updated installation scripts (setup.sh and windows_bat\PokemonGo-Bot-Install.bat)
  3. Updated manual installation doc.
    That would be it, if I haven't missed anything else.

@pogarek pogarek changed the title pgoapi code change is in conflict with bot and virtualbot pgoapi code change is in conflict with bot and virtuaenv Jan 18, 2017
@pogarek pogarek added Help to Test and removed Bug labels Jan 18, 2017
@pogarek pogarek closed this as completed Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants