-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snippng Error: daily catch limit reached #5684
Comments
@Gobberwart can you take a look at it? |
The reason this is happening is because Sniper is overwriting PokemonCatch config. Sniper doesn't have daily_catch_limit so it always uses the default values for PokemonCatch. I think move to map pokemon might be doing the same thing. |
@javajohnHub How does this fix this issue? You're not even calling the base constructor (which calls the abstract initialize()). Neither are Sniper or MTMP 'overriding the PokemonCatch config'. |
It doesnt I thought i deleted it. that was supposed to just be on my repo
You are wrong @YvesHenri a simple: |
@YvesHenri Both MTMP and Sniper do in fact overwrite PokemonCatchWorker config.... well, not so much overwrite as 'supply their own config'. They both create a new instance of PokemonCatchWorker and supply their own config which PokemonCatchWorker uses instead of using the CatchPokemon config it should be using. See PR #5708 for a solution to this which forces PokemonCatchWorker to load CatchPokemon config if supplied/enabled. |
Should be fixed now in dev. Closing. |
Expected Behavior
Snipping should work
Actual Behavior
Snipping gives error: daily catch limit reached, even though the limit is very high
Your FULL config.json (remove your username, password, gmapkey and any other private info)
Output when issue occurred
Steps to Reproduce
Run the bot in the latest commit
Other Information
OS:
Ubuntu 15.04
Branch:
dev
Git Commit:
f60a4b1
Python Version:
Python 2.7.9
The text was updated successfully, but these errors were encountered: