Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CatchLimiter #5666

Closed
mmeulstee opened this issue Sep 25, 2016 · 4 comments
Closed

CatchLimiter #5666

mmeulstee opened this issue Sep 25, 2016 · 4 comments

Comments

@mmeulstee
Copy link

mmeulstee commented Sep 25, 2016

Short Description

I love the new function "CatchLimiter".
{
"type": "CatchLimiter",
"config": {
"enabled": true,
"min_balls": 20,
"duration": 15
}
},

Possible solution

Wouldn't be nicer to have the choice on which Pokeballs you wanna have on 20.
{
"type": "CatchLimiter",
"config": {
"enabled": true,

  •   "min_balls": 20,
    
    •   "pokeball": 15,
      
    •   "greatball": 20,
      
    •   "ultraball": 10,
      
      "duration": 15
      }
      },

How it would help others

@Gobberwart
Copy link
Contributor

I considered that, but wanted to get it at least started without making it too complex. Pending feedback from others, this is an option to consider.

@ghost
Copy link

ghost commented Sep 25, 2016

If this is added, we probably should remove min_ultraball_to_keep from CatchPokemon.

@mmeulstee
Copy link
Author

indeed to not have any conflicts

@Gobberwart
Copy link
Contributor

@acurioustale No need to remove that. Even if we implement this, it will work differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants